Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to date, Cell conversion exception #187

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

Kopilov
Copy link
Contributor

@Kopilov Kopilov commented Nov 22, 2022

When AnyCol.convertTo fails, we now can get more detailed information about the problem cell.

Also convertToLocalDate function added.

(This patch is a part of the next step of saving to Arrow per schema (#169) with encapsulating possible mismatches in a sealed class, but can be useful itself.)

@koperagen
Copy link
Collaborator

koperagen commented Nov 23, 2022

Hi! Nice addition indeed, thank you :)
I'll merge it a bit later, after running tests on CI

@koperagen koperagen merged commit 50e55f3 into Kotlin:master Nov 23, 2022
@Kopilov Kopilov deleted the cell_conversion_exception branch December 2, 2022 14:37
@Jolanrensen Jolanrensen added this to the 0.9.0 milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants