cleaned samples/api files and made sure ktlint will ignore them in th…

…e future
Kotlin · Jun 27, 2024 · 0c66782 · 0c66782
1 parent 813d270
commit 0c66782
Show file tree

Hide file tree

Showing 16 changed files with 297 additions and 193 deletions.
diff --git a/core/build.gradle.kts b/core/build.gradle.kts
@@ -102,14 +102,6 @@ tasks.withType<KspTask> {
     }
 }
 
-tasks.named("runKtlintCheckOverSamplesSourceSet") {
-    onlyIf { false }
-}
-
-tasks.named("runKtlintFormatOverSamplesSourceSet") {
-    onlyIf { false }
-}
-
 val clearTestResults by tasks.creating(Delete::class) {
     delete(layout.buildDirectory.dir("dataframes"))
     delete(layout.buildDirectory.dir("korroOutputLines"))

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Access.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Access.kt
@@ -1,6 +1,58 @@
+@file:Suppress("ktlint")
+
 package org.jetbrains.kotlinx.dataframe.samples.api
 
-import org.jetbrains.kotlinx.dataframe.api.*
+import org.jetbrains.kotlinx.dataframe.api.add
+import org.jetbrains.kotlinx.dataframe.api.after
+import org.jetbrains.kotlinx.dataframe.api.chunked
+import org.jetbrains.kotlinx.dataframe.api.colsOf
+import org.jetbrains.kotlinx.dataframe.api.column
+import org.jetbrains.kotlinx.dataframe.api.columnGroup
+import org.jetbrains.kotlinx.dataframe.api.columnOf
+import org.jetbrains.kotlinx.dataframe.api.countDistinct
+import org.jetbrains.kotlinx.dataframe.api.dataFrameOf
+import org.jetbrains.kotlinx.dataframe.api.distinct
+import org.jetbrains.kotlinx.dataframe.api.distinctBy
+import org.jetbrains.kotlinx.dataframe.api.drop
+import org.jetbrains.kotlinx.dataframe.api.dropLast
+import org.jetbrains.kotlinx.dataframe.api.dropNA
+import org.jetbrains.kotlinx.dataframe.api.dropNaNs
+import org.jetbrains.kotlinx.dataframe.api.dropNulls
+import org.jetbrains.kotlinx.dataframe.api.dropWhile
+import org.jetbrains.kotlinx.dataframe.api.fillNaNs
+import org.jetbrains.kotlinx.dataframe.api.filter
+import org.jetbrains.kotlinx.dataframe.api.filterBy
+import org.jetbrains.kotlinx.dataframe.api.first
+import org.jetbrains.kotlinx.dataframe.api.forEach
+import org.jetbrains.kotlinx.dataframe.api.gather
+import org.jetbrains.kotlinx.dataframe.api.getColumn
+import org.jetbrains.kotlinx.dataframe.api.getColumnGroup
+import org.jetbrains.kotlinx.dataframe.api.getColumns
+import org.jetbrains.kotlinx.dataframe.api.group
+import org.jetbrains.kotlinx.dataframe.api.groupBy
+import org.jetbrains.kotlinx.dataframe.api.into
+import org.jetbrains.kotlinx.dataframe.api.isColumnGroup
+import org.jetbrains.kotlinx.dataframe.api.map
+import org.jetbrains.kotlinx.dataframe.api.mapToRows
+import org.jetbrains.kotlinx.dataframe.api.maxBy
+import org.jetbrains.kotlinx.dataframe.api.maxByOrNull
+import org.jetbrains.kotlinx.dataframe.api.minBy
+import org.jetbrains.kotlinx.dataframe.api.minus
+import org.jetbrains.kotlinx.dataframe.api.move
+import org.jetbrains.kotlinx.dataframe.api.named
+import org.jetbrains.kotlinx.dataframe.api.notNull
+import org.jetbrains.kotlinx.dataframe.api.remove
+import org.jetbrains.kotlinx.dataframe.api.rows
+import org.jetbrains.kotlinx.dataframe.api.select
+import org.jetbrains.kotlinx.dataframe.api.single
+import org.jetbrains.kotlinx.dataframe.api.sortBy
+import org.jetbrains.kotlinx.dataframe.api.take
+import org.jetbrains.kotlinx.dataframe.api.takeLast
+import org.jetbrains.kotlinx.dataframe.api.takeWhile
+import org.jetbrains.kotlinx.dataframe.api.update
+import org.jetbrains.kotlinx.dataframe.api.values
+import org.jetbrains.kotlinx.dataframe.api.withZero
+import org.jetbrains.kotlinx.dataframe.api.xs
 import org.jetbrains.kotlinx.dataframe.explainer.TransformDataFrameExpressions
 import org.jetbrains.kotlinx.dataframe.get
 import org.junit.Test

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Analyze.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Analyze.kt
@@ -1,3 +1,5 @@
+@file:Suppress("ktlint")
+
 package org.jetbrains.kotlinx.dataframe.samples.api
 
 import org.jetbrains.kotlinx.dataframe.api.aggregate

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/ApiLevels.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/ApiLevels.kt
@@ -1,3 +1,5 @@
+@file:Suppress("ktlint")
+
 package org.jetbrains.kotlinx.dataframe.samples.api
 
 import org.jetbrains.kotlinx.dataframe.DataFrame

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Collections.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Collections.kt
@@ -1,3 +1,5 @@
+@file:Suppress("ktlint")
+
 package org.jetbrains.kotlinx.dataframe.samples.api
 
 import io.kotest.matchers.shouldBe
@@ -27,6 +29,7 @@ class Collections {
     @TransformDataFrameExpressions
     fun listInterop2() {
         data class Input(val a: Int, val b: Int)
+
         val list = listOf(Input(1, 2), Input(3, 4))
         // SampleStart
         val df = list.toDataFrame()
@@ -77,6 +80,7 @@ class Collections {
             .group("name", "lastName").into("fullName")
 
         data class FullName(val name: String, val lastName: String)
+
         data class Person(val fullName: FullName, val age: Int)
 
         val persons = df.toListOf<Person>() // [Person(fullName = FullName(name = "John", lastName = "Doe"), age = 21)]

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Create.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Create.kt
@@ -1,3 +1,5 @@
+@file:Suppress("ktlint")
+
 package org.jetbrains.kotlinx.dataframe.samples.api
 
 import io.kotest.matchers.shouldBe
@@ -241,7 +243,7 @@ class Create : TestBase() {
         val df = dataFrameOf("name", "age")(
             "Alice", 15,
             "Bob", 20,
-            "Charlie", 100
+            "Charlie", 100,
         )
         // SampleEnd
     }
@@ -253,7 +255,7 @@ class Create : TestBase() {
         // DataFrame with 2 columns and 3 rows
         val df = dataFrameOf(
             "name" to listOf("Alice", "Bob", "Charlie"),
-            "age" to listOf(15, 20, 100)
+            "age" to listOf(15, 20, 100),
         )
         // SampleEnd
     }
@@ -337,7 +339,7 @@ class Create : TestBase() {
         val values = listOf(
             "Alice", 15,
             "Bob", 20,
-            "Charlie", 22
+            "Charlie", 22,
         )
         val df = dataFrameOf(names, values)
         // SampleEnd
@@ -379,12 +381,14 @@ class Create : TestBase() {
     fun readDataFrameFromDeepObject() {
         // SampleStart
         data class Name(val firstName: String, val lastName: String)
+
         data class Score(val subject: String, val value: Int)
+
         data class Student(val name: Name, val age: Int, val scores: List<Score>)
 
         val students = listOf(
             Student(Name("Alice", "Cooper"), 15, listOf(Score("math", 4), Score("biology", 3))),
-            Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5)))
+            Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5))),
         )
 
         val df = students.toDataFrame(maxDepth = 1)
@@ -400,12 +404,14 @@ class Create : TestBase() {
     @TransformDataFrameExpressions
     fun readDataFrameFromDeepObjectWithExclude() {
         data class Name(val firstName: String, val lastName: String)
+
         data class Score(val subject: String, val value: Int)
+
         data class Student(val name: Name, val age: Int, val scores: List<Score>)
 
         val students = listOf(
             Student(Name("Alice", "Cooper"), 15, listOf(Score("math", 4), Score("biology", 3))),
-            Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5)))
+            Student(Name("Bob", "Marley"), 20, listOf(Score("music", 5))),
         )
 
         // SampleStart

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/DataRowApi.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/DataRowApi.kt
@@ -1,3 +1,5 @@
+@file:Suppress("ktlint")
+
 package org.jetbrains.kotlinx.dataframe.samples.api
 
 import org.jetbrains.kotlinx.dataframe.api.add

diff --git a/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Join.kt b/core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/samples/api/Join.kt
@@ -1,3 +1,5 @@
+@file:Suppress("ktlint")
+
 package org.jetbrains.kotlinx.dataframe.samples.api
 
 import io.kotest.matchers.shouldBe
@@ -60,6 +62,7 @@ class Join : TestBase() {
     }
 
     class Right
+
     val DataFrame<Right>.fullName: ColumnGroup<Name> get() = getColumnGroup("fullName").cast()
 
     @Test