Update kotlin-metadata-jvm #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
force-pushed
the
update-metadata-lib
branch
from
1a92d10 to
3013d41
Compare
fzhinkin
commented
Jul 12, 2024
| @@ -132,10 +131,9 @@ private fun FieldNode.buildFieldSignature( | |||
| } | |||
|
|
|||
| val property = companionClassCandidate?.kmProperty(name) | |||
|
|
|||
| if (property != null && JvmFlag.Property.IS_MOVED_FROM_INTERFACE_COMPANION(property.flags)) { | |||
There was a problem hiding this comment.
That was a bug, and JvmFlag.Property.IS_MOVED_FROM_INTERFACE_COMPANION worked here purely by coincidence.
There was a problem hiding this comment.
Thanks to the new stable API, it became obvious! ;)
sandwwraith
reviewed
Jul 12, 2024
W.r.t. newer metadata versions
shanshin
approved these changes
Jul 15, 2024
|
kotlin-metadata-jvm seems to be API-compatible with Kotlin 1.6, but the API version is not set explicitly. Here's an issue on that: https://youtrack.jetbrains.com/issue/KT-69903 |
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
* Use stable kotlin-metadata-jvm version * Fixed check for properties declared in a companion object * Use readLenient to be more lenient w.r.t. newer metadata versions Pull request Kotlin/binary-compatibility-validator#255
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
* Use stable kotlin-metadata-jvm version * Fixed check for properties declared in a companion object * Use readLenient to be more lenient w.r.t. newer metadata versions Pull request Kotlin/binary-compatibility-validator#255
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
* Use stable kotlin-metadata-jvm version * Fixed check for properties declared in a companion object * Use readLenient to be more lenient w.r.t. newer metadata versions Pull request Kotlin/binary-compatibility-validator#255
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
kotlinx-metadata-jvmwithkotlin-metadata-jvm,and updated the code to use a new API.