-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add SetUnhandledExceptionFilter support to win32 so that crash dump c… #80
base: koffi2
Are you sure you want to change the base?
Conversation
@Koromix Hi, please take some time look at this. I need to make my app whole as soon as possiable.Thanks. |
…an work as expected
Sorry, I don't have much time to work on this right now. Your patch looks good but will have a performance impact, and I'd prefer to find a way to make the SEH unwinder across the Koffi "assembly wall", if possible, so that it can cross the Koffi stack change and frames and properly go up to the default handler. In the mean time, I encourage you to include your alternative build of You don't need to load Koffi through the package Koffi |
@Koromix Hi, thanks for reply. I know waht you mean, but i think it's not possible to across the Koffi "assembly wall", when dispatch exception windows check the every SEH link list node’s address is between stackbase and stacklimit or not , if we link the exceptionlist back to default stack, the check will fail and windows didn't dispatch exception to our handler(try...catch block). The only way i can find for now is modify stackbase and stacklimit to include both the default stack and koffi's stack area, but since windows may have used them anywhere so it's too dangerous. Or do you have a way to cheat windows on this? |
75dcc40
to
52ebc2c
Compare
b8199ea
to
3926b91
Compare
add SetUnhandledExceptionFilter support to win32 so that crash dump can work as expected, to fix Koromix/koffi#155