validate namespace in disconnect call

Fixes miguelgrinberg/Flask-SocketIO#427
KoraLinSar · Nov 19, 2019 · 7379d45 · 7379d45
1 parent 64f63e8
commit 7379d45
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/socketio/base_manager.py b/socketio/base_manager.py
@@ -64,6 +64,8 @@ def pre_disconnect(self, sid, namespace):
 
     def disconnect(self, sid, namespace):
         """Register a client disconnect from a namespace."""
+        if namespace not in self.rooms:
+            return
         rooms = []
         for room_name, room in six.iteritems(self.rooms[namespace]):
             if sid in room:

diff --git a/tests/test_base_manager.py b/tests/test_base_manager.py
@@ -99,6 +99,11 @@ def test_disconnect_with_callbacks(self):
         self.bm.disconnect('123', '/')
         self.assertNotIn('123', self.bm.callbacks)
 
+    def test_disconnect_bad_namespace(self):
+        self.bm.connect('123', '/')
+        self.bm.connect('123', '/foo')
+        self.bm.disconnect('123', '/bar')  # should not assert
+
     def test_trigger_callback(self):
         self.bm.connect('123', '/')
         self.bm.connect('123', '/foo')