Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please provide a rebuild of version 3.1.02 #311

Closed
JoHaHu opened this issue Oct 24, 2019 · 6 comments
Closed

Please provide a rebuild of version 3.1.02 #311

JoHaHu opened this issue Oct 24, 2019 · 6 comments
Labels
Dependency Bug A bug in some dependency that needs patching

Comments

@JoHaHu
Copy link

JoHaHu commented Oct 24, 2019

The org.apache.httpcomponents:httpasyncclient:4.1.4 library that unirest depends on has fixed a bug in httpcore-nio where automatic module name resolution in java 9 and above fails, because they uses an invalid module identifier.
Please provide a rebuild of this library. There is no need to change any version number of any library because httpasyncclient fixed it with same version number.
Otherwise a new version with fixed libray is appreciated aswell.

Thank you!

@JoHaHu JoHaHu closed this as completed Oct 24, 2019
@JoHaHu
Copy link
Author

JoHaHu commented Oct 24, 2019

Sorry they didnt fixed. it my bad.

@ryber
Copy link
Collaborator

ryber commented Oct 24, 2019

Do you have a link to the issue in their issue tracker (I think it's Jira?)

@JoHaHu
Copy link
Author

JoHaHu commented Oct 24, 2019

https://issues.apache.org/jira/browse/HTTPCORE-533

They fixed httpcore-nio, but they didnt fixed their httpasyncclient that uses that library

@ryber
Copy link
Collaborator

ryber commented Oct 24, 2019

It's possible we can simply declare our own dependency on httpcore-nio and override 4.4.10

@JoHaHu
Copy link
Author

JoHaHu commented Oct 24, 2019

That would be nice. It's my current workaround at the moment.

@ryber ryber reopened this Oct 24, 2019
@ryber ryber added the Dependency Bug A bug in some dependency that needs patching label Oct 24, 2019
@JoHaHu
Copy link
Author

JoHaHu commented Oct 25, 2019

I can confirm that the new version fixes my issue. Therefore I am closing this.

@JoHaHu JoHaHu closed this as completed Oct 25, 2019
JoHaHu pushed a commit to JoHaHu/jabref that referenced this issue Oct 25, 2019
JoHaHu pushed a commit to JoHaHu/jabref that referenced this issue Oct 25, 2019
JoHaHu pushed a commit to JoHaHu/jabref that referenced this issue Oct 28, 2019
JoHaHu pushed a commit to JoHaHu/jabref that referenced this issue Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependency Bug A bug in some dependency that needs patching
Projects
None yet
Development

No branches or pull requests

2 participants