Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyform): unpass set,jwk and pem instead of passing null [KM-562] #1701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TT1228
Copy link
Contributor

@TT1228 TT1228 commented Oct 8, 2024

Summary

KM-562

When there is no value, instead of passing null, we don't pass pem, jwk and set in key form, cause koko now enforces null check for these parameters.

@TT1228 TT1228 requested review from a team as code owners October 8, 2024 06:34
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/entities-keys@pr-1701

@Leopoldthecoder
Copy link
Member

LGTM, have you tested in KM?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants