This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(balancer) recover after dns updates #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the health was introduced on the balancer, there is an early exit if the balancer is unhealthy. This introduced a problem where DNS record would remain untouched, and hence would not be refreshed. Leaving the balancer in an unhealthy state forever. A background timer is added to check and update records every second. issue: Kong/kong#4781
kikito
suggested changes
Aug 7, 2019
locao
reviewed
Aug 7, 2019
|
We could change in by and remove the |
Co-Authored-By: Enrique García Cota <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the health was introduced on the balancer, there is an early
exit if the balancer is unhealthy. This introduced a problem where
DNS record would remain untouched, and hence would not be refreshed.
Leaving the balancer in an unhealthy state forever.
issue: Kong/kong#4781