Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kdropdown): update dropdown popover selector #2225

Merged
merged 7 commits into from
Jun 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions docs/.vitepress/theme/_overrides.scss
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,16 @@
}
}
}

.k-alert {
p {
line-height: $kui-line-height-30; // .alert-message line-height
}
}

.k-empty-state {
p {
line-height: $kui-line-height-30; // .empty-state-message line-height
}
}
}
9 changes: 0 additions & 9 deletions docs/components/alert.md
Original file line number Diff line number Diff line change
Expand Up @@ -255,12 +255,3 @@ const showAlert = ref<boolean>(true)
gap: $kui-space-50;
}
</style>

<style lang="scss">
// overwrite vitepress styles
.k-alert {
p {
line-height: $kui-line-height-30; // .alert-message line-height
}
}
</style>
9 changes: 0 additions & 9 deletions docs/components/empty-state.md
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,3 @@ const onActionClick = (): void => {
alert('Action button clicked!')
}
</script>

<style lang="scss">
// overwrite vitepress styles
.k-empty-state {
p {
line-height: $kui-line-height-30; // .empty-state-message line-height
}
}
</style>
2 changes: 1 addition & 1 deletion docs/guide/migrating-to-version-9.md
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ Component has been renamed to `KDropdown`
#### Structure

* `k-dropdown-menu` class has been removed (`k-dropdown` class remains)
* `k-dropdown-menu-popover` `data-testid` attribute has been renamed to `k-dropdown-popover`
* `k-dropdown-menu-popover` `data-testid` attribute has been renamed to `dropdown-popover`
* `k-dropdown-trigger` class has been removed
* `k-dropdown-trigger` `data-testid` attribute has been renamed to `dropdown-trigger`
* `k-dropdown-btn` class has been renamed to `dropdown-trigger-button`
Expand Down
7 changes: 6 additions & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,16 @@ features:
linkText: View changes
---

<style>
<style lang="scss">
/* Homepage Components button */
.VPContent.is-home .VPButton.medium.alt[href^="/components/"] {
color: #fff;
border-color: #07a88d;
background-color: #07a88d;

&:hover {
border-color: #06977E;
background-color: #06977E;
}
}
</style>
6 changes: 0 additions & 6 deletions sandbox/pages/SandboxAlert.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
title="KAlert"
>
<div class="kalert-sandbox">
<SandboxSectionComponent>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=1105%3A733&mode=dev&t=6zTR9N7eIIoXGsX7-1">
Figma
</KExternalLink>
</SandboxSectionComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
12 changes: 1 addition & 11 deletions sandbox/pages/SandboxBadge.vue
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
<template>
<SandboxLayout
:links="inject('app-links', [])"
title="KButton"
title="KBadge"
>
<div class="kbadge-sandbox">
<SandboxTitleComponent
title="KBadge"
>
<template #description>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=467%3A10283&mode=dev">
Figma
</KExternalLink>
</template>
</SandboxTitleComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
6 changes: 0 additions & 6 deletions sandbox/pages/SandboxBreadcrumbs.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
title="KBreadcrumbs"
>
<div class="kbreadcrumbs-sandbox">
<SandboxSectionComponent>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=470%3A22444&mode=dev&t=tS1kk3tqkOVTlZ8a-1">
Figma
</KExternalLink>
</SandboxSectionComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
9 changes: 0 additions & 9 deletions sandbox/pages/SandboxButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,6 @@
title="KButton"
>
<div class="kbutton-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=0%3A1&mode=dev">
Figma
</KExternalLink>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
10 changes: 0 additions & 10 deletions sandbox/pages/SandboxCard.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@
title="KCard"
>
<div class="kcard-sandbox">
<SandboxTitleComponent
title="KCard"
>
<template #description>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=1152%3A19831&mode=dev">
Figma
</KExternalLink>
</template>
</SandboxTitleComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
11 changes: 0 additions & 11 deletions sandbox/pages/SandboxCheckbox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,7 @@
title="KCheckbox"
>
<div class="kcheckbox-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<SandboxSectionComponent>
<div>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=283%3A2899&mode=dev">
Figma
</KExternalLink>
</div>

<div class="grid-container standalone-container">
<div class="vertical-spacing">
<KCheckbox
Expand Down
9 changes: 0 additions & 9 deletions sandbox/pages/SandboxCodeBlock.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,6 @@
title="KCodeBlock"
>
<div class="kcodeblock-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=2020%3A11253&mode=dev&t=wfYkBJZ5Ry0OUS2m-1">
Figma
</KExternalLink>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
13 changes: 2 additions & 11 deletions sandbox/pages/SandboxCollapse.vue
Original file line number Diff line number Diff line change
@@ -1,18 +1,9 @@
<template>
<SandboxLayout
:links="inject('app-links', [])"
title="KPagination"
title="KCollapse"
>
<div class="kpagination-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=2020%3A11254&mode=dev&t=z4m6LiZVAeHHwxSH-1">
Figma
</KExternalLink>

<div class="kcollapse-sandbox">
<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
6 changes: 0 additions & 6 deletions sandbox/pages/SandboxDateTimePicker.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
title="KDateTimePicker"
>
<div class="kdatetimepicker-sandbox">
<SandboxSectionComponent>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=2020%3A11255&mode=dev&t=7C3HUCeWQiS7AhA7-1">
Figma
</KExternalLink>
</SandboxSectionComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
9 changes: 0 additions & 9 deletions sandbox/pages/SandboxDropdown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,6 @@
title="KDropdown"
>
<div class="kdropdown-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=466%3A9443&mode=dev">
Figma
</KExternalLink>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
6 changes: 0 additions & 6 deletions sandbox/pages/SandboxEmptyState.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
title="KEmptyState"
>
<div class="kemptystate-sandbox">
<SandboxSectionComponent>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=2020%3A11252&mode=dev&t=oHjbEUosoGUvnzuN-1">
Figma
</KExternalLink>
</SandboxSectionComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
6 changes: 0 additions & 6 deletions sandbox/pages/SandboxFileUpload.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
title="KFileUpload"
>
<div class="kfileupload-sandbox">
<SandboxSectionComponent>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=285%3A2601&mode=dev">
Figma
</KExternalLink>
</SandboxSectionComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
15 changes: 1 addition & 14 deletions sandbox/pages/SandboxInput.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,8 @@
title="KInput"
>
<div class="kinput-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<SandboxSectionComponent>
<div>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=218%3A646&mode=dev">
Figma
</KExternalLink>
</div>

<div>
<KInput />
</div>
<KInput />
</SandboxSectionComponent>

<!-- Props -->
Expand Down
17 changes: 2 additions & 15 deletions sandbox/pages/SandboxInputSwitch.vue
Original file line number Diff line number Diff line change
@@ -1,24 +1,11 @@
<template>
<SandboxLayout
:links="inject('app-links', [])"
title="KLabel"
title="KInputSwitch"
>
<div class="kinputswitch-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<SandboxSectionComponent>
<div>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=624%3A12900&mode=dev">
Figma
</KExternalLink>
</div>

<div>
<KInputSwitch v-model="vModel0" />
</div>
<KInputSwitch v-model="vModel0" />
</SandboxSectionComponent>

<!-- Props -->
Expand Down
19 changes: 3 additions & 16 deletions sandbox/pages/SandboxLabel.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,10 @@
title="KLabel"
>
<div class="klabel-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<SandboxSectionComponent>
<div>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=418%3A15878&mode=dev">
Figma
</KExternalLink>
</div>

<div>
<KLabel>
This is a label
</KLabel>
</div>
<KLabel>
This is a label
</KLabel>
</SandboxSectionComponent>

<!-- Props -->
Expand Down
6 changes: 0 additions & 6 deletions sandbox/pages/SandboxModals.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
title="KModal & KPrompt"
>
<div class="kmodals-sandbox">
<SandboxSectionComponent>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=1292%3A5056&mode=dev&t=7C3HUCeWQiS7AhA7-1">
Figma
</KExternalLink>
</SandboxSectionComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
9 changes: 0 additions & 9 deletions sandbox/pages/SandboxPagination.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,6 @@
title="KPagination"
>
<div class="kpagination-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=2020%3A12478&mode=dev">
Figma
</KExternalLink>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
6 changes: 0 additions & 6 deletions sandbox/pages/SandboxPop.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
title="KPop"
>
<div class="kpop-sandbox">
<SandboxSectionComponent>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=1470%3A3448&mode=dev&t=qJAFUBmW2m9dkFvT-1">
Figma
</KExternalLink>
</SandboxSectionComponent>

<!-- Props -->
<SandboxTitleComponent
is-subtitle
Expand Down
11 changes: 0 additions & 11 deletions sandbox/pages/SandboxRadio.vue
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,7 @@
title="KRadio"
>
<div class="kradio-sandbox">
<!-- Figma -->
<SandboxTitleComponent
is-subtitle
title="Figma"
/>
<SandboxSectionComponent>
<div>
<KExternalLink href="https://www.figma.com/file/Yze0SWXl5nKjR0rFdilljK/Components?type=design&node-id=763%3A12969&mode=dev">
Figma
</KExternalLink>
</div>

<div class="grid-container standalone-container">
<div class="vertical-spacing">
<KRadio
Expand Down
Loading