Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kslideout): add persistence prop [MA-1928] #1655

Merged
merged 4 commits into from
Aug 30, 2023
Merged

feat(kslideout): add persistence prop [MA-1928] #1655

merged 4 commits into from
Aug 30, 2023

Conversation

mihai-peteu
Copy link
Contributor

Summary

https://konghq.atlassian.net/browse/MA-1928

PR Checklist

  • Conventional Commits all commits follow the conventional commit standards outlined in the main README.
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@netlify
Copy link

netlify bot commented Aug 28, 2023 •
edited
Loading

✅ Deploy Preview for kongponents ready!

Name Link
🔨 Latest commit ec70296
🔍 Latest deploy log https://app.netlify.com/sites/kongponents/deploys/64ef7020b38f4800088a06b2
😎 Deploy Preview https://deploy-preview-1655--kongponents.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihai-peteu
Copy link
Contributor Author

@kaiarrowood fixed the spec! It actually performs a legitimate check now :)

@mihai-peteu
feat(kslideout): add persistence prop
66867b5 
Added new prop to allow slideout to stay open.
@mihai-peteu mihai-peteu requested a review from a team August 30, 2023 16:33
kaiarrowood
kaiarrowood approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@kaiarrowood kaiarrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mihai-peteu mihai-peteu merged commit bacc706 into main Aug 30, 2023
4 checks passed
@mihai-peteu mihai-peteu deleted the feat/ma-1928-persist-slideout branch August 30, 2023 16:49
kongponents-bot pushed a commit that referenced this pull request Aug 30, 2023
@semantic-release-bot
chore(release): 8.123.0 [skip ci]
6ed74fc 
# [8.123.0](v8.122.9...v8.123.0) (2023-08-30)

### Features

* **kslideout:** add persistence prop ([#1655](#1655)) ([bacc706](bacc706))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 8.123.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portikM portikM portikM approved these changes

@kaiarrowood kaiarrowood kaiarrowood approved these changes

@adamdehaven adamdehaven Awaiting requested review from adamdehaven adamdehaven is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mihai-peteu @kongponents-bot @portikM @kaiarrowood