fix(endpoints): propagate next page size param #9029 #9648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksjm
suggested changes
Nov 1, 2022
|
|
||
| local args = self.args.uri | ||
| if args.tags then | ||
| next_page_tags = "&tags=" .. escape_uri(type(args.tags) == "table" and args.tags[1] or args.tags) | ||
| end | ||
|
|
||
| if type(args.size) == "number" then |
There was a problem hiding this comment.
@fffonion I changed this validation in one of the last commits... I believe I need to update this Pull Request
There was a problem hiding this comment.
@jacksjm I tried to rebase but maybe i lost some of your commits. Could you rebase your PR upon master (you can use this PR as start and force push to yours)? Make sure not to use "merge" but "rebase", since we only merge PR with a rebase, if the PR contains merge commits, it may lead to conflicts as order changes.
There was a problem hiding this comment.
nvm, looks like i can do a squash : ) closing this now
oowl
pushed a commit
that referenced
this pull request
Jul 15, 2024
…g the `route` entity" (#9648) Cherry-picked from #13328 Revert Kong/kong-ee#9512 Co-authored-by: Xumin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #9503