fix(router): check empty route field

kong/router/atc_compat.lua

@@ -11,6 +11,7 @@ local server_name = require("ngx.ssl").server_name
 local tb_new = require("table.new")
 local tb_clear = require("table.clear")
 local tb_nkeys = require("table.nkeys")
+local isempty  = require("table.isempty")
 local yield = require("kong.tools.utils").yield
 
 
@@ -68,6 +69,11 @@ local function is_regex_magic(path)
 end
 
 
+local function is_empty_field(f)
+  return f == nil or f == null or isempty(f)
+end
+
+
 -- resort `paths` to move regex routes to the front of the array
 local function paths_resort(paths)
   if not paths then
@@ -139,7 +145,7 @@ end
 
 
 local function gen_for_field(name, op, vals, val_transform)
-  if not vals or vals == null then
+  if is_empty_field(vals) then
     return nil
   end
 
@@ -186,7 +192,7 @@ local function get_atc(route)
     tb_insert(out, gen)
   end
 
-  if route.hosts and route.hosts ~= null then
+  if not is_empty_field(route.hosts) then
     tb_clear(atc_hosts_t)
     local hosts = atc_hosts_t
 
@@ -241,7 +247,7 @@ local function get_atc(route)
     tb_insert(out, gen)
   end
 
-  if route.headers and route.headers ~= null then
+  if not is_empty_field(route.headers) then
     tb_clear(atc_headers_t)
     local headers = atc_headers_t
 

spec/01-unit/08-router_spec.lua

@@ -2067,6 +2067,84 @@ for _, flavor in ipairs({ "traditional", "traditional_compatible", "expressions"
         end)
       end
 
+      describe("check empty route fields", function()
+
+        it("empty methods", function()
+          local use_case = {
+            {
+              service = service,
+              route = {
+                id = "e8fb37f1-102d-461e-9c51-6608a6bb8101",
+                methods = {},
+                paths = { "/foo", },
+                updated_at = 100,
+              },
+            },
+          }
+          assert(new_router(use_case))
+        end)
+
+        it("empty hosts", function()
+          local use_case = {
+            {
+              service = service,
+              route = {
+                id = "e8fb37f1-102d-461e-9c51-6608a6bb8101",
+                hosts = {},
+                paths = { "/foo", },
+                updated_at = 100,
+              },
+            },
+          }
+          assert(new_router(use_case))
+        end)
+
+        it("empty headers", function()
+          local use_case = {
+            {
+              service = service,
+              route = {
+                id = "e8fb37f1-102d-461e-9c51-6608a6bb8101",
+                headers = {},
+                paths = { "/foo", },
+                updated_at = 100,
+              },
+            },
+          }
+          assert(new_router(use_case))
+        end)
+
+        it("empty paths", function()
+          local use_case = {
+            {
+              service = service,
+              route = {
+                id = "e8fb37f1-102d-461e-9c51-6608a6bb8101",
+                methods = { "GET" },
+                paths = {},
+                updated_at = 100,
+              },
+            },
+          }
+          assert(new_router(use_case))
+        end)
+
+        it("empty snis", function()
+          local use_case = {
+            {
+              service = service,
+              route = {
+                id = "e8fb37f1-102d-461e-9c51-6608a6bb8101",
+                snis = {},
+                paths = { "/foo", },
+                updated_at = 100,
+              },
+            },
+          }
+          assert(new_router(use_case))
+        end)
+      end)
+
       describe("normalization stopgap measurements", function()
         local use_case, router