feat(zipkin) support adding trace id in response header #9173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayocream
reviewed
Sep 5, 2022
mayocream
approved these changes
Sep 11, 2022
chronolaw
reviewed
Oct 13, 2022
| @@ -226,6 +226,9 @@ if subsystem == "http" then | |||
|
|
|||
| local proxy_span = get_or_add_proxy_span(zipkin, header_filter_start_mu) | |||
| proxy_span:annotate("khs", header_filter_start_mu) | |||
| if conf.http_response_header_for_traceid then | |||
There was a problem hiding this comment.
local xxx = conf.http_response_header_for_traceid then use it.
windmgc
force-pushed
the
feat-zipkin-expose-trace-id
branch
from
8e49bc8
to
e6e1997
Compare
chronolaw
added a commit
that referenced
this pull request
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new field in Zipkin plugin schema to support adding trace id in the response header.
Full changelog
response_header_for_traceidfield in Zipkin plugin. The plugin will set the corresponding header in the response if the field is specified with a string value.Issue reference
Fix FTI-4198, #8124