Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd) confusing prompt #9114

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix(cmd) confusing prompt #9114

merged 1 commit into from
Jul 21, 2022

Conversation

StarlightIbuki
Copy link
Contributor

It says [Y/n], but doesn't take Y as the default choice.

@StarlightIbuki
fix(cmd) confusing prompt
1abdc31 
It says [Y/n], but doesn't take Y as default choice.
@StarlightIbuki StarlightIbuki requested a review from a team as a code owner July 18, 2022 04:34
@chronolaw
Copy link
Contributor

Yes, normally Y means the default choice, but the code shows it does not deal with empty input.

@fffonion fffonion merged commit c0e88de into master Jul 21, 2022
@fffonion fffonion deleted the fix/cmd_prompt_yn branch July 21, 2022 09:44
locao pushed a commit that referenced this pull request Jun 21, 2024
@oowl
chore(deps): bump lua-resty-kafka from 0.18 to 0.19 (#9114)
ce23304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

Assignees
No one assigned
Labels
core/cli size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StarlightIbuki @chronolaw @fffonion