-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core) explict flag for regex route.path #9027
Conversation
7a38820
to
23aa62a
Compare
9ad709e
to
30583b8
Compare
33870f1
to
a145a20
Compare
13b3f0e
to
301615f
Compare
NOTE: this will break all existing:
In that sense I think this is a too big of a change that comes too close to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is wrong to use ~*
prefix and do case-sensitive matching. The ~
should be case-sensitive match. See: https://github.com/Kong/kong/blob/master/kong/router.lua#L960
We only add ajo
and not i
modifier.
Co-authored-by: Enrique García Cota <[email protected]>
5d2781a
to
59453b8
Compare
Another solution for #9022.
fix CT-344
We need to remember to add migration, and also "back migration" for EE.
PLEASE MERGE AFTER: #9024