Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core) explict flag for regex route.path #9027

Merged
merged 23 commits into from
Jul 7, 2022
Merged

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Jun 29, 2022

Another solution for #9022.

fix CT-344

We need to remember to add migration, and also "back migration" for EE.

PLEASE MERGE AFTER: #9024

@StarlightIbuki StarlightIbuki requested a review from a team as a code owner June 29, 2022 03:24
@StarlightIbuki StarlightIbuki changed the base branch from master to fix/stop-percent-decoding-regex-path June 29, 2022 05:44
kong/db/schema/typedefs.lua Outdated Show resolved Hide resolved
kong/router.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw added this to the 3.0 milestone Jun 29, 2022
chronolaw
chronolaw previously approved these changes Jun 29, 2022
@bungle
Copy link
Member

bungle commented Jun 29, 2022

NOTE: this will break all existing:

  1. scripts that call admin apis and want regexes.
  2. yaml (and other config files) that are used to configure dbless, or import data into control plane, traditional node, or imported by deck.
  3. kong ingress controller might also be affected

In that sense I think this is a too big of a change that comes too close to 3.0.0 release. That said, major version is the version to do these kind of changes. It can be a can of worms. @dndx could you comment on this?

bungle
bungle previously requested changes Jun 29, 2022
Copy link
Member

@bungle bungle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is wrong to use ~* prefix and do case-sensitive matching. The ~ should be case-sensitive match. See: https://github.com/Kong/kong/blob/master/kong/router.lua#L960

We only add ajo and not i modifier.

Base automatically changed from fix/stop-percent-decoding-regex-path to master July 7, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants