-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FT-2563 - FT-2563-no-daos-hash #8988
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f5609fc398c69f3d779d5c292f6a930cd85cc60f.
hanshuebner
force-pushed
the
FT-2563-no-daos-hash
branch
from
June 23, 2022 13:24
3713b67
to
c80e2b8
Compare
kikito
approved these changes
Jun 23, 2022
kikito
previously requested changes
Jun 23, 2022
spec/01-unit/01-db/01-schema/11-declarative_config/01-validate_spec.lua
Outdated
Show resolved
Hide resolved
bungle
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Older Kong version accepted hash-like tables for DAO definitions. This is no longer supported, and with this change, a clear error message is produced if a plugin returns a non-array-like table for its DAO definitions.