fix(api): use POST to add targets to specific upstream #8798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saisatishkarra
changed the title
|
@Kong/gateway-moderators Can someone review and approve and merge this PR. This is blocking https://konghq.atlassian.net/browse/ENGEN-593. |
In Kong 2.x series, for a compatibility with old versions, it was
possible to update targets using POST method. When fixing this
behavior, the path /upstreams/{upstream}/targets was mistakenly changed
to also use PUT method, instead of only blocking adding duplicated
targets. This change fixes this behavior.
locao
force-pushed
the
fix/target_creation_method
branch
from
ff49f02
to
cb38cf2
Compare
kikito
reviewed
May 19, 2022
There was a problem hiding this comment.
The changelog currently contains this note in the Breaking Changes section:
Insert and update operations on target entities require using the PUT HTTP method now. https://github.com/Kong/kong/pull/8596. If you have scripts that depend on it being POST, these scripts will need to be updated when updating to Kong 3.0.
I believe it should be updated according to the changes on this PR. My suggestion:
POST requests on Target entities will no longer be able to update existing entities, they will only be able to create new ones. https://github.com/Kong/kong/pull/8596, https://github.com/Kong/kong/pull/8798. If you have scripts that use POST requests to modify Targets, you should change them to PUT requests before updating to Kong 3.0.
kikito
approved these changes
May 19, 2022
locao
pushed a commit
that referenced
this pull request
Apr 24, 2024
Disable analysis in stream module to avoid unnecessary error logs. FTI-5845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Kong 2.x series it was possible to update targets using
POSTmethod. When fixing this behavior, the path/upstreams/{upstream}/targetswas mistakenly changed to also usePUTmethod, instead of only blocking adding duplicated targets. This PR changes it.Full changelog
PUTin/upstreams/{upstream}/targetsPOST.Cherry-picked fix(balancer) set target status using hostname #8797, in order to the tests to pass.Needed sister PR already merged.FT-2874
DECK-64