Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(plugins/rate-limiting) test ssl connection #8662

Merged
merged 2 commits into from
Apr 11, 2022

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Apr 11, 2022

Summary

This is a retry for #8617, which was rolled back by #8649 because it was unstable.

The SSL connection between the rate-limiting plugin and Redis was not tested.

Difference with #8617

  • Fix a tiny bug in the rate-limiting plugin, if the config.redis_database is 0, the default connection pool should be used.
  • Reissue the server.crt to avoid the server.crt expiration exceed the ca.crt.

Full changelog

  • Fix a tiny bug in the rate-limiting plugin, if the config.redis_database is 0, the default connection pool should be used.
  • Add relevant testing strategies to spec/03-plugins/23-rate-limiting/05-integration_spec.lua.
  • Update .github/workflows/build_and_test.yml to enable SSL for Redis in CI
  • Create folder spec/fixtures/redis and add the following files
    • ca.key: Private key for the root certificate
    • ca.crt: Root Certificate
    • server.key: Private key for Redis server certificate
    • server.crt: Redis server certificate
    • docker-entrypoint.sh: To override the default

These certificates should be added to Kong-Pongo and gojira to make it easy for developers to run tests locally.

Related PR: Kong/gojira#45, Kong/kong-pongo#270

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed plugins/rate-limiting labels Apr 11, 2022
@ADD-SP ADD-SP changed the title Add sp/fix/test redis ssl tests(plugins/rate-limiting) test ssl connection Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed plugins/rate-limiting size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants