fix(plugins): change log level from error to info when restarting external plugin instance #8652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernal plugin instance
mayocream
added
chore
mayocream
reviewed
Apr 11, 2022
github-actions
bot
added
core/language/go
core/language/js
core/language/python
and removed
chore
fffonion
approved these changes
May 25, 2022
|
Thank you @ealogar ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the external plugin instances (go, python, ...) loses the instances_id in a event handler, the instance is restarted to complete the plugin call but a weird error appear:
We change the log level to info as this is not a real problem as the plugin is restarted lately in code (considering the message string as well)