fix(datadog) default value for metrics specified twice #8315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary I found out that datadog schema specifies default for metrics in two levels. Once in config field level and second in metrics level. The config field level causes validation errors in schema loading but those errors are ignored by our loader for some reason. Still I think this is a bug and the default should not be there twice.
hbagdi
reviewed
Jan 21, 2022
| @@ -72,7 +72,6 @@ return { | |||
| { protocols = typedefs.protocols }, | |||
| { config = { | |||
| type = "record", | |||
| default = { metrics = DEFAULT_METRICS }, | |||
There was a problem hiding this comment.
cc @kinman who might be affected by the change
kikito
approved these changes
Feb 21, 2022
kikito
pushed a commit
that referenced
this pull request
Feb 24, 2022
kikito
pushed a commit
that referenced
this pull request
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I found out that datadog schema specifies default for metrics in two levels. Once in config field level and second in metrics level. The config field level causes validation errors in schema loading but those errors are ignored by our loader for some reason. Still I think this is a bug and the default should not be there twice.