-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cache #42
Feature/cache #42
Conversation
BenchmarksThe benchmarks have been executed on the EC2 environment, using:
Without cache (version
|
nice |
Is this already in the 0.4.1 ? |
This is in Kong since the first release. |
@thefosk exactly what I thought it was for (http upstream). :( Any plans for that ? |
ok in the mean time I've added it to the nginx config in kong.yml - for docker. Add parts between the ##CUSTOM CACHING##
|
Btw. Looks like analitics only counts misses. |
Feature/cache
### Summary #### bug fixes - ***:** popup errors from lower functions [a19e9c8](fffonion/lua-resty-acme@a19e9c8) - **autossl:** pass storage config to acme client ([#43](fffonion/lua-resty-acme#43)) [ef1e541](fffonion/lua-resty-acme@ef1e541) #### features - **autossl:** add challenge_start_delay [df4ba0b](fffonion/lua-resty-acme@df4ba0b) - **autossl:** check if domain is whitelisted before cert renewal ([#35](fffonion/lua-resty-acme#35)) [942c007](fffonion/lua-resty-acme@942c007) - **client:** add challenge_start_callback [1c9b2d5](fffonion/lua-resty-acme@1c9b2d5) - **client:** allow to read "alternate" link and select preferred chain ([#42](fffonion/lua-resty-acme#42)) [ff17a74](fffonion/lua-resty-acme@ff17a74) - **storage/vault:** add support for kubernetes auth ([#37](fffonion/lua-resty-acme#37)) [93c2121](fffonion/lua-resty-acme@93c2121)
### Summary #### bug fixes - ***:** popup errors from lower functions [a19e9c8](fffonion/lua-resty-acme@a19e9c8) - **autossl:** pass storage config to acme client ([#43](fffonion/lua-resty-acme#43)) [ef1e541](fffonion/lua-resty-acme@ef1e541) #### features - **autossl:** add challenge_start_delay [df4ba0b](fffonion/lua-resty-acme@df4ba0b) - **autossl:** check if domain is whitelisted before cert renewal ([#35](fffonion/lua-resty-acme#35)) [942c007](fffonion/lua-resty-acme@942c007) - **client:** add challenge_start_callback [1c9b2d5](fffonion/lua-resty-acme@1c9b2d5) - **client:** allow to read "alternate" link and select preferred chain ([#42](fffonion/lua-resty-acme#42)) [ff17a74](fffonion/lua-resty-acme@ff17a74) - **storage/vault:** add support for kubernetes auth ([#37](fffonion/lua-resty-acme#37)) [93c2121](fffonion/lua-resty-acme@93c2121)
### Summary #### bug fixes - ***:** popup errors from lower functions [a19e9c8](fffonion/lua-resty-acme@a19e9c8) - **autossl:** pass storage config to acme client ([#43](fffonion/lua-resty-acme#43)) [ef1e541](fffonion/lua-resty-acme@ef1e541) #### features - **autossl:** add challenge_start_delay [df4ba0b](fffonion/lua-resty-acme@df4ba0b) - **autossl:** check if domain is whitelisted before cert renewal ([#35](fffonion/lua-resty-acme#35)) [942c007](fffonion/lua-resty-acme@942c007) - **client:** add challenge_start_callback [1c9b2d5](fffonion/lua-resty-acme@1c9b2d5) - **client:** allow to read "alternate" link and select preferred chain ([#42](fffonion/lua-resty-acme#42)) [ff17a74](fffonion/lua-resty-acme@ff17a74) - **storage/vault:** add support for kubernetes auth ([#37](fffonion/lua-resty-acme#37)) [93c2121](fffonion/lua-resty-acme@93c2121)
records from the additional section would not be stored in the cache when there already was a cache entry. This also means that stale data was not replaced. The bug surfaced when a dns server would not respond to CNAME queries, but only provide that data alongside an A query. To track the bug extensive logging was added (to be enabled manually), and a script to re-format those logs.
This pull request is the first step in implementing #15, with the final step being having an invalidation system in place.
It implements a time-expiration caching system configurable through
kong.yaml
configuration file.I'm creating the pull request without merging, and will post the results of the benchmark below.