feat(db) move consumers from kong.dao to kong.db #3408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikito
force-pushed
the
feat/consumers-2-db
branch
from
27a97d9
to
ecf5491
Compare
bungle
reviewed
Apr 23, 2018
kong/api/routes/consumers.lua
Outdated
| DELETE = function(self, dao_factory) | ||
| crud.delete(self.consumer, dao_factory.consumers) | ||
| end | ||
| }, | ||
|
|
||
| ["/consumers/:username_or_id/plugins/"] = { |
There was a problem hiding this comment.
Can this be changed to /consumers/:consumers/plugins for future (not also that no / at the end)?
|
|
||
| return { | ||
| name = "consumers", | ||
| primary_key = { "id" }, |
There was a problem hiding this comment.
here we need to add endpoint_key = "username", (see feat/admin-schema-aware-parser)
kikito
force-pushed
the
feat/consumers-2-db
branch
from
ecf5491
to
f8cfca1
Compare
bungle
changed the title
kikito
force-pushed
the
feat/consumers-2-db
branch
from
f8cfca1
to
d19299c
Compare
bungle
reviewed
May 2, 2018
kong/api/routes/consumers.lua
Outdated
|
|
||
| ["/consumers/:username_or_id/plugins/"] = { | ||
| ["/consumers/:username_or_id/plugins"] = { |
There was a problem hiding this comment.
This should be /consumers/:consumers/plugins for future changes (or was it not changed because of a reason?), when plugins are transferred (probably at that point this needs to be removed).
There was a problem hiding this comment.
I have removed the extra "/". Thanks!
There was a problem hiding this comment.
I also renamed username_or_id to consumers on the route.
kikito
force-pushed
the
feat/consumers-2-db
branch
2 times, most recently
from
536d316
to
211ad2f
Compare
kikito
force-pushed
the
feat/consumers-2-db
branch
from
211ad2f
to
adcd198
Compare
|
Closing this in favour of #3437 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves consumers to the new DAO. Notes:
endpoints.luathat allow param parsing using schemas (https://github.com/Kong/kong/compare/feat/admin-schema-aware-parser), so that one should probably be merged before this PR.PUTis gone (for now, @bungle is working on adding it back)/consumers/?created_at=xxx) is no longer possiblecache_keyshould be a DAO method. Maybe it should live in thekong.cachemodule instead?cache.key('consumers', consumer_id)instead ofconsumers:cache_key(consumer_id)singletons.x