[feature] cascade delete of plugins_configurations. fix #107 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
changed the title
2 tasks
|
This PR raises some concerns about the base_dao, since our way of using it evolved a lot recently (also since the pagination was implemented in the driver). Or will evolve as described in #103. I will try to improve it and simplify this PR before merging it. |
This proposes a way to delete all `plugins_configurations` related to `Consumers` or `APIs` when deleting one of the two later. `:delete()` is simply overridden to iterate over all related `plugins_configuration` and delete them one by one. Caveats: - I am very unhappy with how painful it is to use one DAO inside another DAO. To avoid what would appear to be a cycling reference I rather opted for instanciating a new DAO inside of the `delete` method. - It is painful to perform a paginated query through the base_dao. - It is even more painful to perform a find_by_keys query as a paginated query.
thibaultcha
force-pushed
the
feat/cascade-delete
branch
from
8bdaa09 to
925705c
Compare
thibaultcha
added a commit
that referenced
this pull request
May 6, 2015
[feature] cascade delete of plugins_configurations. fix #107
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
[feature] cascade delete of plugins_configurations. fix Kong#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a way to delete all
plugins_configurationsrelated toConsumersorAPIswhen deleting one of the two later.:delete()is simply overridden to iterate over all relatedplugins_configurationand delete them one by one.Caveats:
DAO. To avoid what would appear to be a cycling reference I rather opted
for instanciating a new DAO inside of the
deletemethod.query.