feat(plugin) Adding path prefix support in request transformer

[andyfleming]

Summary

Allows for a path prefix to be prepended or removed.

So with the following configuration...

curl -X POST http://localhost:8001/apis/mockbin/plugins \
  --data "name=request-transformer" \
  --data "config.remove.path_prefix[1]=/example" \
  --data "config.add.path_prefix[1]=/another"

A request to /example/page would be transformed to /another/page

NOTE: I have not set up a full dev environment, so I have not actually tested these changes.

If someone could take a look, I think the changes are pretty straightforward.

Full changelog

• Implemented path prefix support
• Created test

Issues resolved

May address #724

[Tieske]

shouldn't this be sub instead of substr? does this even work...

[andyfleming]

Oops, typo. Good catch! Thanks! Updated in 99b3a63.

[Tieske]

I think xx-api_spec.lua could use some input validation tests, with at a minimum a check on;

• starts with a slash
• does not end with a slash
• valid characters for path (incl. %-encoded)

[andyfleming]

@Tieske — I'm not completely following. What are the specific expectations you have in mind? Are you talking about upon API routing? or setting the plugin settings?

[Tieske]

@andyfleming apologies for not being clear. I meant the plugin settings.

[andyfleming]

@Tieske No worries. Is there another file I can look at that has similar tests to use as a starting point?

[Tieske]

have a look at the existing request-tranformer api specs; https://github.com/Mashape/kong/blob/next/spec/03-plugins/13-request-transformer/02-api_spec.lua

just extend that file with the new tests

[Tieske]

and this is the existing code for checking a path; https://github.com/Mashape/kong/blob/next/kong/dao/schemas/apis.lua#L76-L109

[andyfleming]

It looks like my use case is actually already covered by strip_request_path. I misinterpreted the documentation.

I'm going to close this. If someone else later wants to pursue this functionality, they are welcome to run with it.