-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [AG-113] Gemini transformer plugins, incorrect URL and response error parsers #13703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tysoekong
added
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
backport release/3.8.x
labels
Sep 23, 2024
tysoekong
force-pushed
the
fix/AG-113_gemini_transformer_plugins
branch
from
September 23, 2024 14:52
9bc1685
to
063c199
Compare
team-gateway-bot
added
the
author/community
PRs from the open-source community (not Kong Inc)
label
Sep 23, 2024
tysoekong
force-pushed
the
fix/AG-113_gemini_transformer_plugins
branch
3 times, most recently
from
September 30, 2024 15:50
f9b5367
to
3ee4797
Compare
fffonion
approved these changes
Oct 11, 2024
oowl
approved these changes
Oct 12, 2024
fffonion
force-pushed
the
fix/AG-113_gemini_transformer_plugins
branch
from
October 14, 2024 11:14
3ee4797
to
a612bb7
Compare
Successfully created backport PR for |
Successfully created cherry-pick PR for |
fffonion
pushed a commit
that referenced
this pull request
Oct 17, 2024
…error parsers (#13703) (#13753) * fix(gemini-ai): incorrect URL parser for transformer plugins * fix(ai-transformers): incorrect return parameter used for parser error handling AG-113 (cherry picked from commit b49cf31) Co-authored-by: Jack Tysoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author/community
PRs from the open-source community (not Kong Inc)
backport release/3.8.x
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
plugins/ai-proxy
plugins/ai-request-transformer
plugins/ai-response-transformer
schema-change-noteworthy
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two related issues:
expected #1 got nil
errors to the clientChecklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
AG-133