Feature/cache-locks #1367
Closed
Feature/cache-locks #1367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| local lock = resty_lock:new("cache_locks", { | ||
| exptime = 10, | ||
| timeout = 10 | ||
| }) |
There was a problem hiding this comment.
shouldn't the lock be create on the module level instead of on each call to get_or_set?
There was a problem hiding this comment.
nevermind, the lock can only lock 1 key at a time. So function level lock is required.
subnetmarco
force-pushed
the
feature/cache-semaphore
branch
from
569ba9c
to
a1bcbc6
Compare
|
Fixed typos. |
thibaultcha
added
pr/ready (but hold merge)
|
to be reopened against next |
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting a specific entity from the database, only one request to the database per node is allowed. This dramatically improves reliability during heavy load.
For example: let's say that 1000 req/s are being processed by a Kong node, and suddenly an in-memory entity is being invalidated and Kong needs to read it again from the database. Before this PR Kong would open 1000req/s to the database until that entity is stored into memory again. With this PR, only one read request will be opened to the database (per node), and the other requests (on the same node) will just wait until it's finally in memory again.
This also helps the performance of new nodes that are being added to the cluster (whose load goes from 0 to 100 real quick).
Closes #264.