fix(router/atc): uri replace didn't works well if contains the optional group #13024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/router
cherry-pick kong-ee
team-eng-enablement
added
the
author/community
|
This PR is ready to review now. Could you please take a look while you have time? I'm not sure if I get your point correctly. |
git-hulk
force-pushed
the
fix/request-transformer-uri-replace
branch
2 times, most recently
from
a78738a
to
427967d
Compare
git-hulk
force-pushed
the
fix/request-transformer-uri-replace
branch
from
427967d
to
23ebd29
Compare
StarlightIbuki
requested changes
May 14, 2024
changelog/unreleased/kong/fix-request-transformer-uri-replace.yml
Outdated
Show resolved
Hide resolved
changelog/unreleased/kong/fix-request-transformer-uri-replace.yml
Outdated
Show resolved
Hide resolved
|
@StarlightIbuki Thank you, I did enable the .editorconfig plugin in my IDE, but it seems didn't work correctly. Will take care of this next time. |
chronolaw
reviewed
May 14, 2024
changelog/unreleased/kong/fix-request-transformer-uri-replace.yml
Outdated
Show resolved
Hide resolved
chronolaw
changed the title
chronolaw
reviewed
May 14, 2024
chronolaw
reviewed
May 14, 2024
nowNick
approved these changes
May 14, 2024
changelog/unreleased/kong/fix-request-transformer-uri-replace.yml
Outdated
Show resolved
Hide resolved
StarlightIbuki
requested changes
May 14, 2024
StarlightIbuki
approved these changes
May 14, 2024
chronolaw
reviewed
May 14, 2024
|
@StarlightIbuki @chronolaw Please take a look at the last commit again. |
chronolaw
reviewed
May 14, 2024
Co-authored-by: Chrono <[email protected]>
Co-authored-by: Chrono <[email protected]>
Co-authored-by: Mikołaj Nowak <[email protected]>
Co-authored-by: Xumin <[email protected]>
StarlightIbuki
force-pushed
the
fix/request-transformer-uri-replace
branch
from
0a5df57
to
96e3b95
Compare
ADD-SP
reviewed
May 23, 2024
chronolaw
reviewed
May 23, 2024
git-hulk
commented
May 23, 2024
git-hulk
commented
May 23, 2024
Co-authored-by: hulk <[email protected]>
chronolaw
reviewed
May 23, 2024
git-hulk
commented
May 23, 2024
chronolaw
approved these changes
May 27, 2024
|
Successfully created cherry-pick PR for |
|
Thanks all for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
URI captures are not usable if the first capture is an empty string.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdTicket reference
Fix #13014, KAG-4474