feat(cli) SSL auto-generation + dnsmasq for new CLI #1299
Conversation
subnetmarco
force-pushed
the
refactor/ssl-autogen
branch
3 times, most recently
from
b35cdc9 to
9830033
Compare
subnetmarco
force-pushed
the
refactor/ssl-autogen
branch
from
9830033 to
68a0c29
Compare
|
|
||
| -- Check that the files exist | ||
| if not pl_path.exists(ssl_cert) then | ||
| return false, "Can't find SSL certificate at: "..ssl_cert |
There was a problem hiding this comment.
prefer returning nil, by convention with the rest of the codebase.
There was a problem hiding this comment.
also: to stay consistent, don't capitalize error messages. In the CLI, the errors always appear as:
Error: can't find SSL certificate at: ...
| for _, cmd in ipairs(commands) do | ||
| local ok, _, _, stderr = pl_utils.executeex(cmd) | ||
| if not ok then | ||
| return nil, "There was an error when auto-generating the default SSL certificate: "..stderr |
There was a problem hiding this comment.
ditto (capitalized) + error could be shorter and consistent with the other errors of the CLI: "could not generate the default SSL cert:"
| @@ -1,2 +1,3 @@ | |||
| ssl = on | |||
| dnsmasq = on | |||
| dns_resolver = "8.8.8.8" | |||
… and "serf" folders.
| finally(function() | ||
| helpers.execute(KILL_ALL) | ||
| helpers.dir.rmtree("foobar") | ||
| end) |
There was a problem hiding this comment.
Please be more careful, this test clearly belongs to a category of "errors" test, as stated by the scoping describe. If you change the behavior of the CLI (I won't even discuss the legitimacy of automatically creating a non-existing folder on behalf of the user, that is unexpected behavior to me), this is now testing the opposite. This test should be moved outside of the errors.
|
Agree that passing configuration for stopping a service is not ideal (and it can also be error prone: what happens if somebody updates the configuration files at runtime and then trie to stop/start Kong?). You could store the configuration using nginx's PID as a key (e.g., create a folder for the PID somewhere and store the configuration files for the duration of the application's lifecycle) |
to avoid giving `stop` and other commands a configuration file argument, we now store the configuration in Kong's working directory (or Nginx prefix as it is now refered to).
…efactor/ssl-autogen
thibaultcha
changed the title
kong cluster ..CLInext).pids,logsandserffolders.