feat(plugin) bot-detection #1259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subnetmarco
added
the
pr/ready (but hold merge)
subnetmarco
force-pushed
the
plugins/bot-detection
branch
from
a7905ac to
93b4e60
Compare
thibaultcha
added
pr/status/needs review
and removed
pr/ready (but hold merge)
|
Because the target is 0.9, this should be based of refactor/cli, since some of the changes made here are outdated, and because it removes dependencies such as stringy, for instance. |
|
I take it the other way around: I am waiting for |
|
Ok, it will mean rewriting all the tests too. |
| cache.set(cache.bot_detection_key(key), value) | ||
| local index_keys = cache.get(INDEX) | ||
| if not index_keys then index_keys = {} end | ||
| table.insert(index_keys, key) |
There was a problem hiding this comment.
index_keys[#index_keys+1] = key is the preferred way because faster and cleaner.
thibaultcha
added
pr/changes requested
subnetmarco
force-pushed
the
plugins/bot-detection
branch
from
93b4e60 to
6a161a4
Compare
subnetmarco
added
pr/ready (but hold merge)
thibaultcha
added
pr/changes requested
|
Needs to be reworked with new testing tools after |
This was referenced Jul 17, 2016
|
replaced by #1413 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin detects popular bots from the
User-Agentof the request and forbids them from executing the request.The generic rules hard-coded in the plugin can be overwritten with an array of Regex expressions in a
config.whitelistorconfig.blacklistproperty when adding the plugin.