Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(proxy): use more reasonable keepalive default value for Nginx tuning #12223

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

chobits
Copy link
Contributor

@chobits chobits commented Dec 19, 2023

Summary

Bumped default values of nginx_http_keepalive_requests and upstream_keepalive_max_requests to 10000.

Checklist

Issue reference

Fix KAG-3360

@chobits
Copy link
Contributor Author

chobits commented Dec 19, 2023

do not merge until we have accomplished the performance test of these values.

@bungle
Copy link
Member

bungle commented Dec 19, 2023

perf(template) is wrong perf(proxy) or perf(core) is better.

@chobits
Copy link
Contributor Author

chobits commented Dec 20, 2023

perf(template) is wrong perf(proxy) or perf(core) is better.

Thx, @bungle will use perf(proxy)

@chobits chobits changed the title perf(template): use more reasonable keepalive default value for Nginx tuning perf(proxy): use more reasonable keepalive default value for Nginx tuning Dec 20, 2023
@chobits
Copy link
Contributor Author

chobits commented Dec 20, 2023

The performance test has passed. Whether tuning these parameters shows no significant changes in memory and RPS data. For more details, see KAG-3360's comment

…ning

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360
@dndx dndx merged commit f7e6eee into master Dec 21, 2023
27 checks passed
@dndx dndx deleted the opt_keepalive_param branch December 21, 2023 10:22
@chobits chobits added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Dec 22, 2023
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/2.8.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/2.8.x
git worktree add -d .worktree/backport-12223-to-release/2.8.x origin/release/2.8.x
cd .worktree/backport-12223-to-release/2.8.x
git switch --create backport-12223-to-release/2.8.x
git cherry-pick -x f7e6eeefe006af11129d1b0e39a1c06449a53d42

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.4.x with exitcode 1

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.2.x
git worktree add -d .worktree/backport-12223-to-release/3.2.x origin/release/3.2.x
cd .worktree/backport-12223-to-release/3.2.x
git switch --create backport-12223-to-release/3.2.x
git cherry-pick -x f7e6eeefe006af11129d1b0e39a1c06449a53d42

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12223-to-master-to-upstream' failed with exit code 1

@team-gateway-bot
Copy link
Collaborator

You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID A341:3525:1529C6A:2BDC8D7:65A73030.

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

1 similar comment
@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12223-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12223-to-release/3.3.x
git switch --create backport-12223-to-release/3.3.x
git cherry-pick -x f7e6eeefe006af11129d1b0e39a1c06449a53d42

@team-gateway-bot
Copy link
Collaborator

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

@team-gateway-bot

This comment was marked as resolved.

@team-gateway-bot
Copy link
Collaborator

Git push to origin failed for release/3.5.x with exitcode 1

locao pushed a commit that referenced this pull request Jan 18, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 5, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 5, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 5, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
hanshuebner pushed a commit that referenced this pull request Feb 5, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 6, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
windmgc pushed a commit that referenced this pull request Feb 6, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
chobits added a commit that referenced this pull request Feb 20, 2024
…ing (#12223)

Bumped default values of `nginx_http_keepalive_requests` and
`upstream_keepalive_max_requests` to `10000`.

KAG-3360

---------

Co-authored-by: Datong Sun <[email protected]>
(cherry picked from commit f7e6eee)
AndyZhang0707 added a commit that referenced this pull request Jul 18, 2024
AndyZhang0707 added a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/templates size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants