Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd): remove the restriction that some configuration fields are not #11291

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

catbro666
Copy link
Contributor

@catbro666 catbro666 commented Jul 26, 2023

allowd to reference vaults introduced by #11127
FTI-4937

Copy link
Member

@windmgc windmgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor suggestions

CHANGELOG.md Show resolved Hide resolved
@catbro666 catbro666 force-pushed the remove-vault-reference-limit branch from 9afde39 to 7b341d2 Compare July 26, 2023 06:13
@windmgc windmgc added this to the 3.4.0 milestone Jul 26, 2023
@windmgc windmgc merged commit 522f554 into master Jul 26, 2023
@windmgc windmgc deleted the remove-vault-reference-limit branch July 26, 2023 06:46
team-gateway-bot pushed a commit that referenced this pull request Jul 26, 2023
…#11291)

This commit allows some configuration fields to be referenced by using vaults. The limitation is introduced by #11127, and this commit removes the limitation to keep the behaviour to be the same as before

[FTI-4937](https://konghq.atlassian.net/browse/FTI-4937)

(cherry picked from commit 522f554)
windmgc pushed a commit that referenced this pull request Jul 26, 2023
…#11291)

This commit allows some configuration fields to be referenced by using vaults. The limitation is introduced by #11127, and this commit removes the limitation to keep the behaviour to be the same as before

[FTI-4937](https://konghq.atlassian.net/browse/FTI-4937)

(cherry picked from commit 522f554)
@kikito kikito mentioned this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants