-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(plugin/prometheus): generate metrics output data with string.buffer #11065
Conversation
@oowl , could you do the same performance test for this PR again? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think maybe we can contribute these performances related patches to https://github.com/knyar/nginx-lua-prometheus upstream, because prometheus.lua
was a fork with upstream.
3f34eac
to
4489931
Compare
Sorry, performance test environment was destroy in last month |
Sure, Do we have someone responsible for tracking or syncing the nginx-lua-prometheus upstream? |
Summary
This PR follows #11040, continue to optimize the string usage by string.buffer.
KAG-1852
Checklist
Full changelog
table.new
forseen_metrics
buffered_print()
outputs a string, not a tableprintable_metric_data
of stream to fit the newbuffered_print()
ipairs
to iterate array