fix(tracing) lower tracing_sampling_rate to 0.01 #10774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kikito
force-pushed
the
fix/lower-tracing-sampling
branch
3 times, most recently
from
3c21b6d
to
6f38494
Compare
|
The admin API spec change looks unrelated. I suggest sending a separate PR for it. |
kikito
force-pushed
the
fix/lower-tracing-sampling
branch
from
6f38494
to
dd2ffef
Compare
samugi
requested changes
May 3, 2023
kikito
force-pushed
the
fix/lower-tracing-sampling
branch
from
5332ee8
to
e6d8282
Compare
samugi
approved these changes
May 5, 2023
team-gateway-bot
pushed a commit
that referenced
this pull request
May 5, 2023
(cherry picked from commit b269802)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Lower the default for tracing_sampling_rate. Tracing every request is not operative for any production system.
Notice that tracing_sampling_rate = 1 is appropriate for testing purposes, where it's more convenient and faster to always produce traces.
Checklist
Full changelog
Changed default value of tracing_sampling_rate from 1 to 0.01
Issue reference
FTI-5032