Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clustering): version compatibility for acme #10689

Merged
merged 1 commit into from
Apr 18, 2023
Merged

fix(clustering): version compatibility for acme #10689

merged 1 commit into from
Apr 18, 2023

Conversation

catbro666
Copy link
Contributor

@catbro666 catbro666 commented Apr 17, 2023 •
edited
Loading

Summary

fix version compatibility for acme. The original PR missed to add the field into removed_fields.lua

KAG-615

oowl
oowl reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog entry to changelog.md

@catbro666
Copy link
Contributor Author

Please add changelog entry to changelog.md

This fix may not be worth recording to changelog. The original PR missed to add the field into removed_fields.lua. This PR is to fix it.

@hanshuebner hanshuebner merged commit 193242f into master Apr 18, 2023
@hanshuebner hanshuebner deleted the acme-redis-namespace-compat branch April 18, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl left review comments

@hanshuebner hanshuebner hanshuebner approved these changes

Assignees

@catbro666 catbro666

Labels
core/clustering size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catbro666 @hanshuebner @oowl