fix(otel): spans hierarchy + sampled flags and propagation #10663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
changed the title
samugi
force-pushed
the
fix/otel-span-hierarchy-sampled-flags
branch
from
0f736cd
to
c9e1ce3
Compare
samugi
changed the title
samugi
changed the title
samugi
force-pushed
the
fix/otel-span-hierarchy-sampled-flags
branch
from
c9e1ce3
to
516a6c1
Compare
addresses span hierarchy for otel, similarly to what Kong/kong-ee#4904 did for dd
address propagation of non-sampled spans, similarly to what Kong/kong-ee#5054 did for dd
samugi
force-pushed
the
fix/otel-span-hierarchy-sampled-flags
branch
from
516a6c1
to
3719b95
Compare
samugi
force-pushed
the
fix/otel-span-hierarchy-sampled-flags
branch
4 times, most recently
from
fe98a81
to
40faabc
Compare
samugi
force-pushed
the
fix/otel-span-hierarchy-sampled-flags
branch
from
40faabc
to
25e893b
Compare
samugi
commented
Apr 14, 2023
| @@ -500,6 +517,7 @@ local function set(conf_header_type, found_header_type, proxy_span, conf_default | |||
| end | |||
|
|
|||
| if conf_header_type == "ot" or found_header_type == "ot" then | |||
| to_ot_trace_id = to_ot_trace_id or require "kong.plugins.opentelemetry.otlp".to_ot_trace_id | |||
There was a problem hiding this comment.
moved here otherwise requiring "propagation" from "instrumentation" was resulting in otlp to be initialized too soon
samugi
force-pushed
the
fix/otel-span-hierarchy-sampled-flags
branch
from
25e893b
to
a09f69e
Compare
| @@ -82,6 +83,15 @@ function _M.balancer(ctx) | |||
| local try_count = balancer_data.try_count | |||
| local upstream_connect_time = split(var.upstream_connect_time, ", ", "jo") | |||
|
|
|||
| local last_try_balancer_span | |||
There was a problem hiding this comment.
Nice to have those decoupled from the OTEL plugin. Eventually, we will also decouple the creation of root span and "last_try_balancer_span` too.
StarlightIbuki
approved these changes
Apr 17, 2023
|
@samugi This will need to be cherry-picked into EE |
ms2008
added a commit
that referenced
this pull request
Jun 1, 2023
Zipkin manages its spans and calls `finish` on them, and the result is that `finish` is called twice if instrumentations are enabled. Then an assertion error is generated, resulting in the span not being sent correctly. This was an issue introduced with #10663 So my approach is not to store the propagation span if the reuse parameter is not specified, in order to avoid the traces not being generated correctly under that.
3 tasks
samugi
pushed a commit
that referenced
this pull request
Jun 1, 2023
* fix(zipkin): do not reuse `propagated_span` by default Zipkin manages its spans and calls `finish` on them, and the result is that `finish` is called twice if instrumentations are enabled. Then an assertion error is generated, resulting in the span not being sent correctly. This was an issue introduced with #10663 So my approach is not to store the propagation span if the reuse parameter is not specified, in order to avoid the traces not being generated correctly under that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of #10583 and #10655 (otel plugin side).
Addresses the following issues:
Checklist
Full changelog
Issue reference
KAG-1108