Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin/rate-limiting): use redis:eval() to improve rate-limiting accuracy #10559

Merged
merged 8 commits into from
May 31, 2023
Merged

fix(plugin/rate-limiting): use redis:eval() to improve rate-limiting accuracy #10559

merged 8 commits into from
May 31, 2023

Commits on May 31, 2023

  1. fix rate-limiting accuracy reported on issue: Kong#5311 

    it is same fix made in PR Kong#8227, but I remove sliding-window feature.
Kong have no plans to add a sliding window to this plugin, Sliding window is an enterprise-only feature at this point
    @giovanibrioni @ADD-SP
    giovanibrioni authored and ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    5debe06 View commit details
    Browse the repository at this point in the history

  2. fix with @hanshuebner comments

    @giovanibrioni @ADD-SP
    giovanibrioni authored and ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f44d019 View commit details
    Browse the repository at this point in the history

  3. Update kong/plugins/rate-limiting/policies/init.lua 

    Co-authored-by: Chrono <[email protected]>
    @giovanibrioni @chronolaw @ADD-SP
    2 people authored and ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    a8b6486 View commit details
    Browse the repository at this point in the history

  4. style: remove leading spaces

    @ADD-SP
    ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    e6f9c3c View commit details
    Browse the repository at this point in the history

  5. tests(rate-limting): fix permission of redis user for testing

    @ADD-SP
    ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    4edda4a View commit details
    Browse the repository at this point in the history

  6. tests: add a test for redis policy

    @ADD-SP
    ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    bf9adfb View commit details
    Browse the repository at this point in the history

  7. docs(CHANGELOG): add entry

    @ADD-SP
    ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    3e6ba47 View commit details
    Browse the repository at this point in the history

  8. add comments for tests

    @ADD-SP
    ADD-SP committed May 31, 2023
    Configuration menu
    Copy the full SHA
    9eb755e View commit details
    Browse the repository at this point in the history