Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin): convert traceid in http response headers to hex format #10534

Merged
merged 5 commits into from Mar 24, 2023
Merged

chore(plugin): convert traceid in http response headers to hex format #10534

merged 5 commits into from Mar 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Mar 21, 2023

Summary

Checklist

Full changelog

  • [Implement ...]

Issue reference

#10270

Fix #[issue number]

@ghost ghost marked this pull request as ready for review March 21, 2023 13:28
kong/plugins/opentelemetry/handler.lua Outdated Show resolved Hide resolved
@ghost ghost requested a review from gszr March 23, 2023 12:35
@hbagdi hbagdi assigned ghost Mar 24, 2023
@gszr gszr merged commit 14a64bf into Kong:master Mar 24, 2023
@hbagdi
Copy link
Member

hbagdi commented Mar 27, 2023

This seems to be a fix rather than a chore. Please follow our contributor guidelines (CONTRIBUTING.md).

@hbagdi
Copy link
Member

hbagdi commented Mar 27, 2023

@gszr Could you please cherry pick to enterprise?

@hbagdi
Copy link
Member

hbagdi commented Apr 3, 2023

@gszr Ping on above.

@hbagdi
Copy link
Member

hbagdi commented Apr 4, 2023

@gszr Poke

@gszr
Copy link
Member

gszr commented Apr 5, 2023

@hbagdi I have taken a few minutes to check on this; a pending CE to EE merge needs to be merged before this can be cherry-picked.

@gszr
Copy link
Member

gszr commented Apr 5, 2023

This seems to be a fix rather than a chore. Please follow our contributor guidelines (CONTRIBUTING.md).

This had been fixed at merge time -- see the merged commit 14a64bf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants