fix(plugins/oauth2): OAuth2 token was being cached to nil while access to the wrong service first #10522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the wrong service first
vm-001
changed the title
ghost
reviewed
Mar 20, 2023
ghost
reviewed
Mar 20, 2023
…-service-not-match
windmgc
approved these changes
Apr 9, 2023
windmgc
deleted the
fix/oauth2-token-being-cached-to-nil-while-service-not-match
branch
|
@hbagdi Thanks for the ping. Checked, the community edition to enterprise edition merge process has included this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The OAuth2 plugin caches a nil value for an access token on the condition of the token is valid but does not match the current service. If using this token to access the correct service later, Kong will always return 401 due to the cache issue.
Checklist
Issue reference
FTI-4922