feat(proxy): make error responses content type compliant with request header values #10366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
feat/kag-723-error-handling
branch
2 times, most recently
from
65e1887
to
8f83939
Compare
samugi
changed the title
samugi
changed the title
ensure error messages are returned via kong.response.error when the proxy request is interrupted so that the output formats are compliant with the value of the Accept header
samugi
force-pushed
the
feat/kag-723-error-handling
branch
from
c9c73ca
to
1fac978
Compare
hanshuebner
approved these changes
Feb 28, 2023
curiositycasualty
pushed a commit
that referenced
this pull request
Oct 15, 2024
…cope (#13719) (#10366) (cherry picked from commit 7558b4d) Co-authored-by: Andy Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mostly based on: #7087. Ensure error messages are returned via kong.response.error when the proxy request is short-circuited, so that the output formats are compliant with the value of the Accept header.
Checklist
Full changelog
Issue reference
Fix #7093
KAG-723
KAG-750