feat(ip-restriction): Add TCP Support

[scrudge]

Summary

This change adds TCP support to the ip-restriction plugin by implementing the Stream module's preread function.

When a TCP connection is rejected due to IP restriction rules, a JSON error response is written to the stream and the connection is closed.

Checklist

• The Pull Request has tests
• There's an entry in the CHANGELOG
• Link to docs pr: Add changelog entry for 3.4.x changes in the ip-restriction plugin docs.konghq.com#5736

Full changelog

• Add protocols to schema: "tcp", "tls", "grpc", "grpcs"
• Implement preread function
• Make handler logic generic to be shared by HTTP and TCP

Issue reference

Fix #6679

KAG-722

[chronolaw]

This PR is almost the same with #10229, What is the relation?

[scrudge]

We work on the same team. We need this feature in 2.8.x because we can't upgrade to v3 yet.

[chronolaw]

Could you add some test cases for this PR? Thanks.

[scrudge]

Could you add some test cases for this PR? Thanks.

Sure, but I'm completely lost on how testing works here. is this the test for this plugin :
https://github.com/Kong/kong/blob/master/t/01-pdk/03-ip/01-is_trusted.t

Also, is there some docs on how testing works? Thanks.

[chronolaw]

This plugin's test should be spec/03-plugins/17-ip-restriction.
Perhaps we do not have a proper doc for the test, but don't worry, we can implement the feature first.

[scrudge]

Yeah, I found the tests right after I asked :-)

I'm actually working on the other suggested changed ATM.
I'll also try to fix the test that are broken from the change in response message.

[scrudge]

@hanshuebner @bungle

There's one remaining comment. I think I've resolved the issue, just waiting for feedback.
#10245 (comment)

[hbagdi]

Please add an entry to CHANGELOG.md.

[scrudge]

Could you please add some return statements (it makes code cleaner about its intent).

@bungle can you please approve changes you requested? Thank you.

[scrudge]

Could you please add some return statements (it makes code cleaner about its intent).

@bungle can you please approve changes you requested? Thank you.

@hanshuebner @hbagdi
I believe this PR is held waiting for a response from @bungle but I haven't heard from him since his original comment. Is there anyway to get this completed?
Thanks for all the help.

Feedback has been addressed, ngx.exit is no longer used.

[hanshuebner]

@scrudge Thank your for your contribution!

[scrudge]

Thank you for all your help.

…

On Sat, Jul 8, 2023, 8:54 AM Hans Hübner ***@***.***> wrote: @scrudge <https://github.com/scrudge> Thank your for your contribution! — Reply to this email directly, view it on GitHub <#10245 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAS4RZRV36J36FL3EPKEGUTXPDYXZANCNFSM6AAAAAAUS4K6SQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>