fix(plugins/statsd & opentelemetry): add return values for funcs called in batch queue #10052
Conversation
|
opentelemetry always creates a batch queue with retry_count=0, I didn't find a way to write a test case for it. |
|
Tests are still failing. |
chronolaw
changed the title
|
Notice: we should use the correct PR title, it is important for reviewers. |
mayocream
force-pushed
the
plugins/add-return-values-for-processes-used-in-batch_queue
branch
from
8fad2ec
to
5423842
Compare
liverpool8056
force-pushed
the
plugins/add-return-values-for-processes-used-in-batch_queue
branch
from
478822b
to
db86ed4
Compare
liverpool8056
force-pushed
the
plugins/add-return-values-for-processes-used-in-batch_queue
branch
3 times, most recently
from
66c59d3
to
6e73663
Compare
| assert(#metrics == metrics_count, err) | ||
| end) | ||
|
|
||
| -- wait until shdict metrics could be sent again |
There was a problem hiding this comment.
Will this introduce flakiness? I am good if it isn't. 🤔
There was a problem hiding this comment.
This test case aims to ensure the changes(add return values) for functions of statsd plugins called in batch_queue won't be called repeatedly when the functions executed successfully. In this test case, I try to wait more metrics than it should be, actually , it should timeout as expected (because no more metrics then expected).
The next one is waiting for the shdict metrics being refreshed so that the third test case can pass.
I tried several times in my local environment successfully, so I think it won't be flaky.
In that case, it shouldn't be a critical problem in the opentelemetry plugin, it causes no effects. |
|
The DataDog plugin also uses the batch queue and returns a falsey value in it's log function: kong/kong/plugins/datadog/handler.lua Line 105 in 62adb14 |
|
@rspurgeon I have another PR #10044 for datadog |
that will be processed in batch queue for these two plugins. Batch queue considers the result of processing falsy without return value, namely nil, resulting the batch being reprocessed. FTI-4645
…t to the first test case
liverpool8056
force-pushed
the
plugins/add-return-values-for-processes-used-in-batch_queue
branch
from
eee869f
to
bf0d789
Compare
liverpool8056
force-pushed
the
plugins/add-return-values-for-processes-used-in-batch_queue
branch
from
62ffbdb
to
f4a6a52
Compare
dndx
deleted the
plugins/add-return-values-for-processes-used-in-batch_queue
branch
…0126) * fix(plugins/datadog): add return value for log function in batch queue (#10044) The log function in Datadog is called by the batch queue when a batch is processed, and batch queue relys on the return value of the callback. The return value of log function in Datadog always return `nil`, this makes batch queue consider the result of processing as failed. In this commit, the correct return value indicating the success in processing to fix this bug. * fix(plugins/statsd & opentelemetry): add return values for batch queue callback functions (#10052) Add return values for functions that will be processed in batch queue for these two plugins. Batch queue considers the result of processing unsuccessful without a return value, resulting the batch being reprocessed incorrectly. FTI-4645 Co-authored-by: Robin Xiang <[email protected]>
Summary
fix(plugins/statsd & opentelemetry): add return values for functions that will be processed in batch queue for these two plugins. Batch queue considers the result of processing falsy without return value, resulting the batch in being reprocessed.
Checklist
Issue reference
FTI-4645