fix(grpc-gateway) clear up output buffer when getting partial response (

#12) Fix #9
Kong · Jun 17, 2021 · 5f936ba · 5f936ba
1 parent 70d3587
commit 5f936ba
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/kong/plugins/grpc-gateway/deco.lua b/kong/plugins/grpc-gateway/deco.lua
@@ -276,5 +276,9 @@ function deco:downstream(chunk)
   return chunk
 end
 
+function deco:get_raw_downstream_body()
+  return self.downstream_body
+end
+
 
 return deco
diff --git a/kong/plugins/grpc-gateway/handler.lua b/kong/plugins/grpc-gateway/handler.lua
@@ -84,10 +84,14 @@ function grpc_gateway:body_filter(conf)
   end
 
   local ret = dec:downstream(ngx_arg[1])
-  -- fall through if we can't decode response
-  -- or it's empty
   if not ret or #ret == 0 then
-    return
+    if ngx_arg[2] then
+      -- it's eof and we still cannot decode, fall through
+      ret = deco:get_raw_downstream_body()
+    else
+      -- clear output if we cannot decode, it could be body is not complete yet
+      ret = nil
+    end
   end
   ngx_arg[1] = ret
 end