fix(*) only mount logs directory and use a different prefix (#474) #482
+24
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Kong 3.0 unix sockets have been introduced and spurious failures have been observed on MacOS and Windows systems when using Pongo.
The issue is the unix-sockets being created by Kong (inside the container) on the filesystem that is mounted from the host. This is not supported on Windows and MacOS, though seems to work most of the time, just not always (exact cause unclear).
The fix is 2 fold;
The Pongo change in this PR will make it work if the Kong patch is available, but if it isn't then it will always fail, instead of only occasionally. Confirmed versions to fail:
3.2+bothCEandEE.Hence this PR will only work with Kong versions that have been patched. At the time of writing that is:
3.6+, bothCEandEE(not released yet, but the fix is inmaster)3.4 EELTS, patch version3.4.2.1+So this PR is NOT to be merged, since it will break existing Pongo users.