Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ld_path): setting the LD_LIBRARY_PATH broke some tools #390

Merged
merged 2 commits into from
Mar 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ check [this blogpost on the Kong website](https://konghq.com/blog/custom-lua-plu
| | | (_) | | | | (_| | (_) |
\_| \___/|_| |_|\__, |\___/
__/ |
|___/ v2.5.0
|___/ v2.6.0

Usage: pongo action [options...] [--] [action options...]

Expand Down Expand Up @@ -811,13 +811,24 @@ The result should be a new PR on the Pongo repo.

---

## 2.5.x unreleased
## 2.6.0 released 23-Mar-2023

* Feat: Kong OSS 3.2.2

* Feat: Kong Enterprise 3.2.2.0

* Feat: Kong Enterprise 3.2.1.0

* Fix: Add missing `fuser` and `netstat` utility that is required for certain test functions
[#384](https://github.com/Kong/kong-pongo/pull/384).

* Fix: compile rocks using the Kong shipped crypto libraries
[#382](https://github.com/Kong/kong-pongo/pull/382).

* Fix: setting the LD_PATH broke some other tools. If needed now has to be set
on a per-plugin basis.
Tieske marked this conversation as resolved.
Show resolved Hide resolved
[#390](https://github.com/Kong/kong-pongo/pull/390).

---

## 2.5.0 released 7-Feb-2023
Expand Down
4 changes: 1 addition & 3 deletions pongo.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

function globals {
# Project related global variables
PONGO_VERSION=2.5.0
PONGO_VERSION=2.6.0

local script_path
# explicitly resolve the link because realpath doesn't do it on Windows
Expand Down Expand Up @@ -1143,7 +1143,6 @@ function main {
-e KONG_LICENSE_DATA \
-e KONG_TEST_DONT_CLEAN \
-e PONGO_CLIENT_VERSION="$PONGO_VERSION" \
-e LD_LIBRARY_PATH=/kong-plugin:/usr/local/kong/lib \
kong \
"$WINDOWS_SLASH/bin/bash" "-c" "bin/busted --helper=$WINDOWS_SLASH/pongo/busted_helper.lua ${busted_params[*]} ${busted_files[*]}"
;;
Expand Down Expand Up @@ -1213,7 +1212,6 @@ function main {
-e KONG_CUSTOM_PLUGINS="$CUSTOM_PLUGINS" \
-e PS1_KONG_VERSION="$shellprompt" \
-e PS1_REPO_NAME="$repository_name" \
-e LD_LIBRARY_PATH="/kong-plugin:/usr/local/kong/lib" \
$script_mount \
$history_mount \
kong $exec_cmd
Expand Down