feat: allow building pongo image from specially tagged test image #348
+70
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the possibility to specify a temporary test image as KONG_IMAGE, similar to using the 'dev' and 'dev-ee' pseudo versions. The image name contains the git tag from which it was built. The added logic will determine KONG_VERSION and whether we're dealing with CE or EE from the image name
|
@hanshuebner i was working on running pongo with current commit of build and found this PR might be related. is this PR still we want to persue? if so could you describe what's left/what's not working so i can pick up? |
|
@fffonion If I remember right, this was pretty much working but nobody except myself tested it and it was basically forgotten. I have no plans working on it, but feel free to involve me if there is anything I can help with to get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the possibility to specify a temporary test image as KONG_IMAGE, similar to using the 'dev' and 'dev-ee' pseudo versions. The image name contains the git tag from which it was built. The added logic will determine KONG_VERSION and whether we're dealing with CE or EE from the image name