style(redis) change default redis cluster name from rc to `redis-cl…
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…usters` `rc` is ambiguous and change to `redis-clusters` in accord with Kong/kong-ee#3603 (comment)
|
could this potentially break someones setup or tests? |
This won't break anything else as the only PR uses this value so far is https://github.com/Kong/kong-ee/pull/3603 that is not merged yet. |
fffonion
approved these changes
Oct 31, 2022
Please note that Pongo is extensively used in users CI setups, so there is more to it than just the Kong internal plugins. |
|
@outsinre can you add a changelog entry? |
Should I modify the Readme.md file at https://github.com/Kong/kong-pongo/tree/master#unreleased? |
|
just create a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
style(redis) change default redis cluster name from
rctoredis-clustersrcis ambiguous and change toredis-clustersin accord with https://github.com/Kong/kong-ee/pull/3603#discussion_r993053879