Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(consumer): add credential pages #33

Merged
merged 2 commits into from
Jul 18, 2023
Merged

feat(consumer): add credential pages #33

merged 2 commits into from
Jul 18, 2023

Conversation

Leopoldthecoder
Copy link
Member

@Leopoldthecoder Leopoldthecoder commented Jul 18, 2023 •
edited by jira bot
Loading

Summary

This PR adds list and form pages for the consumer credential entity. Mainly borrowed code from kong-admin, and the NativeEntityForm component is migrated over as well because it's quite different from EntityForm that is already in this repo.

KAG-2105

raoxiaoyan
raoxiaoyan approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@raoxiaoyan raoxiaoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and local manual test work well.

@Leopoldthecoder Leopoldthecoder merged commit 8ae7271 into main Jul 18, 2023
4 checks passed
@Leopoldthecoder Leopoldthecoder deleted the feat/consumer-credentials branch July 18, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoxiaoyan raoxiaoyan raoxiaoyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leopoldthecoder @raoxiaoyan