Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base_url not generated from spec [#6663] #8075

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Oct 14, 2024

Closes #6663

Because there's already a baseEnvironment in the workspace, we ignored the one from openapi-3 importer.

This fix will make it so the .data of the workspace's base environment will get replaced with what comes from the importer - so that the requests will work as {{_.base_url}} will now get added into the base environment.

Note: Another issue, though it can be handled in a separate PR - when importing a spec - it follows through the scanResources and points out envs and requests correctly - but this is only used for the preview part of import - once we import, we create an almost empty design doc, with only the spec filled out

@filfreire filfreire requested a review from a team October 14, 2024 10:47
@filfreire filfreire marked this pull request as draft October 14, 2024 13:49
@jackkav jackkav marked this pull request as ready for review October 14, 2024 15:34
@filfreire filfreire enabled auto-merge (squash) October 14, 2024 15:35
@filfreire filfreire merged commit fdc6a4a into Kong:develop Oct 14, 2024
8 checks passed
@filfreire filfreire deleted the fix/6663 branch October 14, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: generate request collection does not generate the environment variables used in the requests
2 participants