Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use NSIS installer for windows [INS-3983] #7837

Closed

Conversation

filfreire
Copy link
Member

@filfreire filfreire commented Aug 14, 2024

Related to INS-3983

In this PR we explore moving to NSIS.
Reasoning for moving to NSIS:

  • Potentially fix Insomnia not having permissions to write on app data folder - NSIS allows to install insomnia on System-level instead of User's AppData level;
  • According to electron-builder docs, squirrel is deprecated.
  • Give user option of where to install Insomnia at.

Concerns:

  • Auto-update behavior for existing users on past Squirrel builds
  • Conflicting double-installations, e.g. an older one on %Appdata% existing at the same time as System level NSIS installs on C:/Program Files.

Related PR: #7838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant