Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain folder sort when app is re-opened #7372

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mandarbansod
Copy link
Contributor

@mandarbansod mandarbansod commented May 4, 2024

Closes #7130, #5751

###Background
After I click the sort button the sorting is applied but after restart of the IDE it is reset to "Manual" and the previous sorting is lost. Also drag & drop of folders and requests does not work at all after clicking the sort button.

This was caused by two issues:

  • seems code was reading values from search parameters which are always undefiend
  • code never saved the most recent/latest sort order so that when ever user re-opens the IDE, the sorting is preserved

###Changes

  • New type for Folder/Collection sort orders
  • Leverage local storage to set the most recent sort order user has selected
  • default sort order to be alphabatical sort asc

@CLAassistant
Copy link

CLAassistant commented May 4, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jackkav jackkav requested a review from gatzjames May 17, 2024 05:51
@jackkav jackkav closed this Jul 12, 2024
@jackkav jackkav reopened this Jul 12, 2024
gatzjames
gatzjames previously approved these changes Aug 1, 2024
@gatzjames
Copy link
Contributor

Thanks for the PR! LGTM!

@toddnguyen47
Copy link

Is this feature still being looked at? It would be a great quality of life!

@gatzjames gatzjames merged commit a2ddeba into Kong:develop Sep 20, 2024
8 checks passed
CurryYangxx added a commit that referenced this pull request Sep 23, 2024
CurryYangxx added a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort order of project folders reset after restart and drag & drop broken
5 participants